[pmg-devel] [PATCH pmg-api] add depdends on gpg

[Stoiko Ivanov]

On Thu, 5 Sep 2019 16:24:13 +0200
Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:

> On 03.09.19 12:21, Stoiko Ivanov wrote:
> > running `sa-update` without explicitly specifying '--no-gpg' invokes the `gpg`
> > binary. PMG::API2::Spamassassin uses `sa-update` for updating spamassassin
> > rulesets.
> > 
> > Since the functionality is broken when gpg is not installed (and we don't want
> > to disable gpg-verification by default) this patch adds gpg as Depends.  
> 
> as proxmox-spamassassin ships sa-updates, why not add there a Depends/Recommends?
Thought about this initially too - but then checked debian's spamassassin package,
which has neither depends nor recommends. The shipped cronjob for sa-update does also
not really rely on it (it exits if gpg is not found...)

After a quick chat with Dominik we came to the conclusion, that if pmg-api uses the
sa-update (without explicitly disabling gpg), then it's the package which depends
on gpg in order to function correctly.

OTOH adding a Recommends on gpg to proxmox-spamassassin does not sound wrong either..

Not too attached to either solution - and will gladly send the patch for
proxmox-spamassassin if we agree on this way.


> 
> > 
> > Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> > ---
> > reported via form and also affects our current appliance-template:
> > https://forum.proxmox.com/threads/error-gpg-required-but-not-found-it-is-not-recommended-but-you-can-use-sa-update-with-the-no-gpg-to-skip-the-verification.57565/
> > 
> >  debian/control | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/debian/control b/debian/control
> > index 1b19b9f..8751fa6 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -41,6 +41,7 @@ Depends: apt,
> >           clamdscan,
> >           fetchmail,
> >           fonts-font-awesome,
> > +         gpg,
> >           libapt-pkg-perl,
> >           libarchive-perl,
> >           libarchive-zip-perl,
> >   
>