[pmg-devel] [PATCH pmg-api] restart postfix after first installing pmg-api

[Fabian Grünbichler]

On Fri, Jul 26, 2019 at 01:25:13PM +0200, Dominik Csapak wrote:
> On 7/26/19 11:59 AM, Fabian Grünbichler wrote:
> > On Fri, Jul 26, 2019 at 11:23:34AM +0200, Dominik Csapak wrote:
> > > when installing on debian, restarting postfix is necessary for it
> > > to change the bind address (default is 127.0.0.1)
> > > 
> > > Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> > > ---
> > >   debian/postinst | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/debian/postinst b/debian/postinst
> > > index ae8d275..8f84fc6 100644
> > > --- a/debian/postinst
> > > +++ b/debian/postinst
> > > @@ -32,6 +32,7 @@ case "$1" in
> > >   		    deb-systemd-invoke reload-or-try-restart postgresql.service
> > >   		fi
> > >   		pmgconfig sync --restart
> > > +		deb-systemd-invoke restart postfix.service
> > 
> > why not the usual '>/dev/null || true' ?
> > 
> > also, I wonder if the whole block isn't wrong:
> > 
> > for an upgrade, we only do 'pmgconfig sync'. for a fresh install, we do
> > reload-or-try-restart of postgresql and 'pmgconfig sync --restart'
> > 
> > isn't this reversed? and shouldn't we always do a 'pmgconfig sync
> > --restart' (since that should only restart services if needed anyway)?
> > 
> 
> yeah the >/dev/null || true sound about right

I'll apply this + fixup then, and

> 
> about the restart..
> 
> we only would need a 'restart' on a package upgrade when the
> default templates change
> 
> and afaik we never did update the templates
> 
> so while it would not hurt, we really need it
> when first changing the default templates
> 
> should i send a v2 with the redirection||true
> or can you take this issue for now (as i am on holiday next week)

we'll take care of this next week or when you return ;)