[pbs-devel] [PATCH v7 proxmox-backup 09/10] ui: expose GC atime cutoff in datastore tuning option

Christian Ebner c.ebner at proxmox.com
Thu Mar 20 14:17:10 CET 2025


Allows to set the atime cutoff for phase 2 of garbage collection in
the datastores tuning parameters. This value changes the time after
which a chunk is not considered in use anymore if it falls outside of
the cutoff window.

Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
changes since version 6:
- no changes

 www/Utils.js                |  5 +++++
 www/datastore/OptionView.js | 11 +++++++++++
 2 files changed, 16 insertions(+)

diff --git a/www/Utils.js b/www/Utils.js
index 9bd7e1615..13b5eceda 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -850,6 +850,11 @@ Ext.define('PBS.Utils', {
 	delete tuning['gc-atime-safety-check'];
 	options.push(`${gettext('GC Access Time Safety Check')}: ${gc_atime_safety_check ?? true}`);
 
+	let gc_atime_cutoff = tuning['gc-atime-cutoff'];
+	delete tuning['gc-atime-cutoff'];
+	gc_atime_cutoff = gc_atime_cutoff ?? '1445';
+	options.push(`${gettext('GC Access Time Cutoff')}: ${gc_atime_cutoff}m`);
+
 	for (const [k, v] of Object.entries(tuning)) {
 	    options.push(`${k}: ${v}`);
 	}
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index eb846ab76..f29574169 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -283,6 +283,17 @@ Ext.define('PBS.Datastore.Options', {
 			    uncheckedValue: 0,
 			    deleteDefaultValue: true,
 			},
+			{
+			    xtype: 'proxmoxintegerfield',
+			    name: 'gc-atime-cutoff',
+			    emptyText: gettext('1445 (24 hours 5 minutes)'),
+			    fieldLabel: gettext('GC atime Cutoff'),
+			    autoEl: {
+				tag: 'div',
+				'data-qtip': gettext('Cutoff for atime in minutes'),
+			    },
+			    deleteEmpty: true,
+			},
 		    ],
 		},
 	    },
-- 
2.39.5





More information about the pbs-devel mailing list