[pbs-devel] [PATCH v5 proxmox 2/8] pbs api types: add option to set GC chunk cleanup atime cutoff

[Christian Ebner]

On 3/19/25 10:01, Thomas Lamprecht wrote:
> Am 19.03.25 um 09:48 schrieb Christian Ebner:
>> Given this I did check also the output in the docs, which however shows
>> the very unintuitive integer rage and default value.
>>
>> So given that, maybe it would be better to switch from an integer schema
>> to a string schema and parse the values as HumanTime?
>> Similar to what is done for the GC schedule.
> 
> That might indeed have some benefits UX wise, albeit I'm not 100% sure how
> good this is in  the web UI, or is there a pre-existing use case for
> HumanTime in the UI and thus ideally have already a nice validator there to
> provide quicker feedback to users if they enter something bogus.

I think this could be done in the schema validation function, but have 
to take a closer look.

> As the GC schedule is a calendar event, i.e. time instants not really time
> durations like HumanTime is, e.g. `daily` or `hourly`, which calendar event
> support would not make that much sense here.

Yes, these would definitely need to be excluded.

> That said, while I have some slight reservations those probably could be
> resolved with some frontend validation, and it probably would not get
> worse than plain minutes, albeit I'd expect that most people either will
> reduce this to the minimum of 1 to ensure GC collects chunks without
> references much faster or leave it as is, so not sure how much hassle
> this is worth it, at least for this specific duration setting.

Okay, will take a closer look, if it requires to much adaption we can 
keep it as integer schema (+ your improvement suggestions).