[pbs-devel] [PATCH proxmox-backup] datastore: destroy: delete s3 in-use marker unconditionally

[Lukas Wagner]

On Wed Jul 30, 2025 at 5:23 PM CEST, Christian Ebner wrote:
> Currently, the in-use marker object for datastores backed by s3
> backend is only removed together with the data when all data is
> requested to be removed.
>
> It the data should be preserved, the in-use marker should however
> also be removed, allowing to reuse the datastore on the same or
> a different host without force overwriting the marker.
>
> Therefore, unconditionally clear the in-use marker from the S3
> object store. In order to use the predefined marker filename
> constant move it so it can be used during destruction as well.
>
> Suggested-by: Lukas Wagner <l.wagner at proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>

[...]

Looks good to me. Quickly tested this by removing a datastore (without
ticking 'remove data') and then reimporting without ticking 'overwrite
in-use marker'. Also verified via the `mc` tool that the `.in-use`
marker is removed from the bucket, with the `.chunks` and `.cnt` dirs
still being in place as expecteded.

Reviewed-by: Lukas Wagner <l.wagner at proxmox.com>
Tested-by: Lukas Wagner <l.wagner at proxmox.com>