[pbs-devel] [PATCH proxmox-backup v2 8/8] ui: switch datastore destroy label text on backend type

[Christian Ebner]

Load also the backend configuration via the rstore, but do not show
it in the grid. By passing the backend type along to the datastore
destroy window, the destroy all data checkbox label is set based on
the given type.

Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner at proxmox.com>
Tested-by: Lukas Wagner <l.wagner at proxmox.com>
---
changes since version 1:
 - added this patch previously send as followup
 - adapted code to use extjs native accessor methods

 www/datastore/OptionView.js | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 913bdfc74..2f9aa9ebe 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -18,6 +18,10 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
                     ? gettext('All backup snapshots and their data will be permanently destroyed!')
                     : gettext('Configuration change only, no data will be deleted.'),
             destroyNoteCls: (get) => (get('destroyData') ? 'pmx-hint' : ''),
+            destroyCheckboxLabel: (get) =>
+                get('backendType') === 's3'
+                    ? gettext('Remove data from S3 bucket and local cache (dangerous!)')
+                    : gettext('Destroy all data (dangerous!)'),
         },
     },
 
@@ -46,10 +50,10 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
         {
             xtype: 'proxmoxcheckbox',
             name: 'destroy-data',
-            boxLabel: gettext('Destroy all data (dangerous!)'),
             defaultValue: false,
             bind: {
                 value: '{destroyData}',
+                boxLabel: '{destroyCheckboxLabel}',
             },
         },
         {
@@ -70,6 +74,12 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
             },
         },
     ],
+
+    initComponent: function () {
+        let me = this;
+        me.getViewModel().set('backendType', me.backendType);
+        me.callParent();
+    },
 });
 
 Ext.define('PBS.Datastore.Options', {
@@ -118,7 +128,15 @@ Ext.define('PBS.Datastore.Options', {
 
         removeDatastore: function () {
             let me = this;
+            let backendType = 'filesystem';
+            let backend = me.getView().getStore().getById('backend');
+
+            if (backend) {
+                let backendConfig = PBS.Utils.parsePropertyString(backend.get('value'), 'type');
+                backendType = backendConfig.type;
+            }
             Ext.create('PBS.window.SafeDatastoreDestroy', {
+                backendType: backendType,
                 datastore: me.getView().datastore,
             });
         },
@@ -164,6 +182,10 @@ Ext.define('PBS.Datastore.Options', {
     },
 
     rows: {
+        backend: {
+            required: false,
+            visible: false,
+        },
         'notification-mode': {
             required: true,
             defaultValue: 'notification-system',
-- 
2.47.2