[pbs-devel] [PATCH proxmox-backup v2 0/8] remove objects from s3 backend on datastore destroy

[Christian Ebner]

This patch series makes sure the datastore contents are also removed
from the s3 backend if the datastore is destroyed with the remove all
data flag being set.

The first 6 patches fix clippy warnings and refactor the s3 client from
datastore config generation into a dedicated helper, since the last
patch requires that as well and this would be the third ocurence thereof.

Patch 0007 finally does the object store cleanup if the datastore is
backed by s3 and the data should be removed. This simply clears all
contents starting with the store prefix from the bucket.

The last patch switches the label for the datastore destroy dialog,
making it clear that data destruction includes s3 objects and locally
cached data.

Changes since version 1:
- Added ui patch which was previously send as followup, including the
  suggested code cleanup changes.

Christian Ebner (8):
  tree wide: fix useless borrow warnings
  client: backup writer: elide lifetime which can be auto inferred
  api: tape: fix clippy warning on map iteration
  datastore: fix clippy warning checking file extension
  datastore: fix clippy warning to use ? on option
  datastore: add helper to get s3 client from datastore config
  datastore: delete all objects on datastore destroy with remove data
  ui: switch datastore destroy label text on backend type

 pbs-client/src/backup_writer.rs    |   4 +-
 pbs-config/src/datastore.rs        |   2 +-
 pbs-datastore/src/datastore.rs     |  64 +++++++++++++---
 src/api2/config/datastore.rs       | 119 +++++++++--------------------
 src/api2/config/tape_backup_job.rs |   2 +-
 src/api2/tape/restore.rs           |   2 +-
 www/datastore/OptionView.js        |  24 +++++-
 7 files changed, 120 insertions(+), 97 deletions(-)

-- 
2.47.2