[pbs-devel] [PATCH proxmox 0/3] s3 client: improve error logging for invalid requests

[Lukas Wagner]

On Wed Jul 23, 2025 at 12:25 PM CEST, Christian Ebner wrote:
> This patches improve error logging by refactoring the logging logic
> into a common helper and also covering responses with response status
> BAD_REQUEST. This has not been covered previously and helps to
> diagnose the reason for the bad request. In example, a malformed
> request might return the following response body:
>
> ```
> <?xml version="1.0" encoding="UTF-8"?>
> <Error>
>     <Code>MalformedXML</Code>
>     <Message>The XML you provided was not well formed or did not validate against our published schema.</Message>
> </Error>
> ```
>
> Christian Ebner (3):
>   s3 client: fix minor whitespace issue
>   s3 client: refactor error response body into dedicated helper
>   s3 client: log error response body for invalid request status codes
>
>  proxmox-s3-client/src/api_types.rs       |  1 -
>  proxmox-s3-client/src/response_reader.rs | 56 ++++++++++--------------
>  2 files changed, 23 insertions(+), 34 deletions(-)

Looks good to me:

Reviewed-by: Lukas Wagner <l.wagner at proxmox.com>