[pbs-devel] applied: [PATCH proxmox{, -backup} 0/3] followups for PBS s3 backend

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 22 22:25:21 CEST 2025


Am 22.07.25 um 18:36 schrieb Christian Ebner:
> These are followup patches to be applied on top of the patch series
> found here:
> https://lore.proxmox.com/pbs-devel/20250722101106.526438-1-c.ebner@proxmox.com/T/
> 
> Most notably, they fix a regression introduced in version v11, as
> discovered by Lukas. The api now did incorrectly return also the secret
> key for s3 endpoint configurations.
> 
> Further, there is a patch which checks bucket access during datastore
> creation already in the api, before spawning the datastore create task.
> By this, if the bucket cannot be accessed, the user is notified right
> away and does not need to re-enter all the datastore configurations.
> 
> proxmox:
> 
> Christian Ebner (1):
>   s3 client: split config api type into 3 config structs
> 
>  proxmox-s3-client/src/api_types.rs | 62 ++++++++++++++++++++++++------
>  proxmox-s3-client/src/client.rs    |  3 +-
>  2 files changed, 52 insertions(+), 13 deletions(-)
> 
> proxmox-backup:
> 
> Christian Ebner (2):
>   config: s3: adapt to new config struct layouts
>   datastore: check s3 bucket access before create datastore task
> 
>  pbs-config/src/s3.rs           |  7 ++--
>  pbs-datastore/src/datastore.rs | 11 +++--
>  src/api2/admin/s3.rs           |  7 ++--
>  src/api2/config/datastore.rs   | 76 ++++++++++++++++++++++++----------
>  src/api2/config/s3.rs          | 65 ++++++++++++++++++++---------
>  5 files changed, 114 insertions(+), 52 deletions(-)
> 


applied, thanks!




More information about the pbs-devel mailing list