[pbs-devel] [PATCH proxmox{, -backup} v8 00/54] fix #2943: S3 storage backend for datastores

Lukas Wagner l.wagner at proxmox.com
Fri Jul 18 15:16:32 CEST 2025


I'm now done reviewing the 'proxmox-backup' patches (all except the docs patch, I need a bit of a break before that)
Left a couple of comments, but most of that was just relatively minor stuff.

I really liked how you split your work into quite small patches, that made reviewing
this huge series quite manageable (still quite exhausting of course, more than 5 hours in).
I'm not super familiar with some of the inner workings of the backup server, so my review
mostly focused on style and coding practices - so there might be things on the
conceptual level that I might have missed.

Overall, great work Chris!

-- 
- Lukas





More information about the pbs-devel mailing list