[pbs-devel] [PATCH proxmox-backup v3 6/7] ui: add run-on-mount checkbox to SyncJob form

[Christian Ebner]

On 6/4/25 14:30, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> ---
>   www/window/SyncJobEdit.js | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 4cef9a1d..73a489f1 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -195,7 +195,7 @@ Ext.define('PBS.window.SyncJobEdit', {
>   			xtype: 'pbsCalendarEvent',
>   			name: 'schedule',
>   			fieldLabel: gettext('Sync Schedule'),
> -			emptyText: gettext('none (disabled)'),
> +			emptyText: gettext('none'),
>   			cbind: {
>   			    deleteEmpty: '{!isCreate}',
>   			    value: '{scheduleValue}',
> @@ -451,6 +451,17 @@ Ext.define('PBS.window.SyncJobEdit', {
>   			uncheckedValue: false,
>   			value: false,
>   		    },
> +		    {
> +			xtype: 'proxmoxcheckbox',
> +			name: 'run-on-mount',
> +			fieldLabel: gettext('Run when mounted'),
> +			autoEl: {
> +			    tag: 'div',
> +			    'data-qtip': gettext('Run this job when a relevant removable datastore is mounted.'),
> +			},
> +			uncheckedValue: false,
> +			value: false,
> +		    },
>   		],
>   	    },
>   	    {

nit: pre-existing for other boolean flags here as well, but this should 
make sure that it is set as `delete` value if set to it's default. 
Otherwise this is not removed from the sync job config, but set to the 
default instead. Removing it will help reduce the size of the config and 
improve it's readability.