[pbs-devel] applied-series: [PATCH pxar 0/3] pxar: make payload reference offset checks stricter

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Aug 27 14:36:28 CEST 2025


applied, thanks

On Wed, Aug 27, 2025 at 11:46:30AM +0200, Christian Ebner wrote:
> This patch series aims to block the encoding of possible corrupt split
> pxar archives due to the payload reference offsets not being strict
> monotonically increasing. This is a requirement for the sequential
> decoder to be able to restore the contents from a sequential stream.
> 
> This should also help to detect more corrupt encodings as reported in
> the community forum and therefore narrow down the still lingering
> logical issue, still under investigation.
> 
> First two patches are style cleanups only, the third contains the
> stricter encoder check.
> 
> [0] https://forum.proxmox.com/threads/170211/
> 
> pxar:
> 
> Christian Ebner (3):
>   tree wide: fix formatting via `cargo fmt`
>   tree wide: elide explicit lifetimes reported by cargo clippy
>   encoder: improve consistency check for payload reference offsets
> 
>  examples/pxarcmd.rs     |  2 +-
>  src/accessor/aio.rs     |  4 +--
>  src/accessor/mod.rs     |  6 ++--
>  src/accessor/read_at.rs |  6 ++--
>  src/accessor/sync.rs    |  8 ++---
>  src/decoder/aio.rs      |  2 +-
>  src/decoder/mod.rs      |  6 ++--
>  src/decoder/sync.rs     |  2 +-
>  src/encoder/aio.rs      |  4 +--
>  src/encoder/mod.rs      | 76 +++++++++++++++++++++++++++++------------
>  src/encoder/sync.rs     |  4 +--
>  src/lib.rs              |  2 +-
>  tests/compat.rs         |  2 +-
>  tests/simple/fs.rs      |  8 ++---
>  tests/simple/main.rs    |  4 +--
>  15 files changed, 85 insertions(+), 51 deletions(-)
> 
> 
> Summary over all repositories:
>   15 files changed, 85 insertions(+), 51 deletions(-)
> 
> -- 
> Generated by git-murpp 0.8.1




More information about the pbs-devel mailing list