[pbs-devel] [PATCH proxmox-backup v2 0/3] pbs3to4: rework bootloader checks

[Shannon Sterz]

On Thu Aug 21, 2025 at 4:17 PM CEST, Stoiko Ivanov wrote:
> v1->v2:
> Shannon caught a logic-error (wrong negation) in the check if systemd-boot
> is actually used, and a useless temporary variable. additionally patch 2/3
> needed a rustfmt - huge thx!
>
> supersedes:
> https://lore.proxmox.com/pbs-devel/20250818194026.840749-1-s.ivanov@proxmox.com/T/#t
>
> Stoiko Ivanov (3):
>   pbs3to4: fix logic error and typo in log message
>   pbs3to4: use boolean variable for systemd-boot installation state
>   pbs3to4: bootloader: only allow systemd-boot before upgrade when used
>
>  src/bin/pbs3to4.rs | 61 ++++++++++++++++++++++++----------------------
>  1 file changed, 32 insertions(+), 29 deletions(-)

looks good to me, tested this series on the following set ups:

- legacy-mode boot -> outputs `SKIP: System booted in legacy-mode - no
  need for additional packages`
- proxmox-boot-tool + grub but without secure boot -> outputs `FAIL:
  systemd-boot meta-package installed. This will cause problems [..]`
- zfs + systemd-boot (no secure boot, but uefi) -> outputs `SKIP: not
  yet upgraded, systemd-boot still needed for bootctl`

so consider this:

Reviewed-by: Shannon Sterz <s.sterz at proxmox.com>
Tested-by: Shannon Sterz <s.sterz at proxmox.com>