[pbs-devel] [PATCH proxmox-backup] fix #5946: api: disks: directory: fix unknown task status when partition creation fails

Filip Schauer f.schauer at proxmox.com
Mon Aug 11 15:03:09 CEST 2025


On 04/06/2025 13:28, Fabian Grünbichler wrote:
> On April 22, 2025 5:03 pm, Filip Schauer wrote:
>> This shows a more helpful error status than "unknown", when the
>> directory creation task fails during creation of the partition on disk.
>> The full error message can still be viewed in the task log.
>>
>> Signed-off-by: Filip Schauer<f.schauer at proxmox.com>
>> ---
>> Is there a cleaner way to handle this?
> I am not sure I understand the issue - is {err} sometimes just
> "unknown"? I think then improving that error message would make more
> sense..
>
> or how does replacing one Error with another Error fix the problem?

The real problem was that the task status could not be detected when the
error message spanned over multiple lines, since only the last line was
inspected.
Patch v2 fixes the task status detection for multi-line log messages.

Superseded by:
https://lore.proxmox.com/pbs-devel/20250811125839.267803-1-f.schauer@proxmox.com/T





More information about the pbs-devel mailing list