[pbs-devel] [PATCH proxmox-backup 1/1] ui: login: opt the tfa challenge handling into the new HttpOnly flow
Shannon Sterz
s.sterz at proxmox.com
Wed Aug 6 12:20:37 CEST 2025
On Wed Aug 6, 2025 at 12:09 PM CEST, Thomas Lamprecht wrote:
> On Wed, 06 Aug 2025 11:57:02 +0200, Shannon Sterz wrote:
>> this was missed previously leading to the tfa part of the auth flow
>> not opting into the new auth flow. this meant the server did not add a
>> Set-Cookie header. after that whether or not a login worked fine
>> became a race between the refresh logic (which was opted into the new
>> flow and, thus, would yield a proper HttpOnly cookie) and other
>> requests.
>>
>> [...]
>
> Applied, thanks!
>
> tiny nit: we would prefer camelCase in JS, but that's just internal so we can
> change it at any time with a fallback to the previous property.
yes sorry, noticed that after i send it, just send a follow-up. snake
case is too much of a habbit at this point ^^'
> [1/1] ui: login: opt the tfa challenge handling into the new HttpOnly flow
> commit: 4e7c0d6a264557e4e9eea3b0cae2a97260848469
More information about the pbs-devel
mailing list