[pbs-devel] applied: [PATCH proxmox] proxmox-product-config: fix code documentation on permissions

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Aug 5 18:43:08 CEST 2025


On Wed, 07 May 2025 17:36:39 +0200, Laurențiu Leahu-Vlăducu wrote:
> This patch fixes the documentation of some functions being
> inconsistent with the actual code. While such inconsistencies are
> never good, when it comes to permissions, they might have even worse
> consequences.
> 
> To be precise, this patch fixes the following:
> - replace_config() actually uses permissions 0640 (docs stated 0660)
> - although the possibility of setting a privileged user (usually root,
> but possibly different) has been added in the past, the docs still
> stated "root" or "superuser". However, some functions also explicitly
> use "root", which made it even more confusing. It is now clear which
> functions use the API user, which use the privileged user, and which
> explicitly use root.
> - fixed some small style inconsistencies (e.g. priv-user instead
> of priv_user)
> 
> [...]

Applied, thanks!

[1/1] proxmox-product-config: fix code documentation on permissions
      commit: 0dcc45957c8df30ffc37ef2f5b3974d74b535ba7




More information about the pbs-devel mailing list