[pbs-devel] applied-series: [PATCH proxmox-backup v3 0/5] ACL removal on user/token deletion + token regeneration

Thomas Lamprecht t.lamprecht at proxmox.com
Sat Apr 5 19:12:39 CEST 2025


Am 04.04.25 um 17:32 schrieb Hannes Laimer:
> If a user is deleted, all its permissions and tokens
> will now be deleted with it. If a token is deleted
> all its permissions will now be deleted.
> Until now neither of those two happened[1].
> The last two commits add the possibility to regenerate
> tokens, basically revoking the old and generating a
> new secret while keeping all the set permissions.
> 
> This is all in the same series since just adding the
> removal of permissions would kill the currently only
> way to keep the permissions but change the secret of
> a token(deleting it and creating it again with the
> same name[2]).
> 
> -> pbs-api-types dep has to be bumped since we need the schema added in #4
> for #5.
> 
> v3, thanks @Chris:
> - fix problem in where user/acl config wasn't saved on user deletion
> 
> v2:
> - rebase onto master
> 
> [1] https://bugzilla.proxmox.com/show_bug.cgi?id=4382
> [2] https://bugzilla.proxmox.com/show_bug.cgi?id=3887
> 
> Hannes Laimer (5):
>   pbs-config: move secret generation into token_shadow
>   fix #4382: api: access: remove permissions of token on deletion
>   fix #4382: api: remove permissions and tokens of user on deletion
>   fix #3887: api: access: allow secret regeneration
>   fix #3887: ui: add regenerate token button
> 
>  pbs-config/Cargo.toml          |  1 +
>  pbs-config/src/token_shadow.rs | 10 +++-
>  src/api2/access/user.rs        | 83 ++++++++++++++++++++++++++++------
>  www/config/TokenView.js        | 29 ++++++++++++
>  4 files changed, 107 insertions(+), 16 deletions(-)
> 


applied series, re-ordered the regenerate button in the top-bar to
be near other buttons that change state and added a separator to
add some more visual distinction, thanks!




More information about the pbs-devel mailing list