[pbs-devel] applied: [PATCH v2 proxmox-backup 2/6] server: pull: refactor snapshot pull logic

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 2 15:54:27 CEST 2025


Am 18.03.25 um 12:39 schrieb Christian Ebner:
> In preparation for skipping over snapshots when synchronizing with
> encrypted/verified only flags set. In these cases, the manifest has
> to be fetched from the remote and it's status checked. If the
> snapshot should be skipped, the snapshot directory including the
> temporary manifest file has to be cleaned up, given the snapshot
> directory has been newly created. By reorganizing the current
> snapshot pull logic, this can be achieved more easily.
> 
> The `corrupt` flag will be set to `false` in the snapshot
> prefiltering, so the previous explicit distinction for newly created
> snapshot directories must not be preserved.
> 
> No functional changes intended.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 1:
> - no changes
> 
>  src/server/pull.rs | 33 ++++++++++++++++-----------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
> 
>

applied this one already, thanks!

maybe it makes sense to combine the is_new and corrupt flags into a struct
for passing around, but even if, that is probably better done independent
of this series and with some hindsight.




More information about the pbs-devel mailing list