[pbs-devel] [PATCH proxmox-backup] pxar-bin: remove `log` dependency, use `tracing` directly

Gabriel Goller g.goller at proxmox.com
Wed Sep 4 15:27:57 CEST 2024


On 04.09.2024 10:06, Christian Ebner wrote:
>small nits inline
>
>As you already discussed with Wolfgang in the other thread, any user 
>facing output not intended for debugging, e.g. the output of the `pxar 
>list` might be better displayed by writing to stdout using a `println` 
>instead.

I think it's better if we do this later in a more comprehensive series
where we change the behavior in all proxmox clients.

>Tested by listing and extracting a pxar archive, with and without the 
>`PXAR_LOG=debug` environment variable set.
>
>Other than that, please consider this and the patch to `proxmox-log`:
>
>Tested-by: Christian Ebner <c.ebner at proxmox.com>
>Reviewed-by: Christian Ebner <c.ebner at proxmox.com>

Thanks a lot for the review!
Sent a v2!




More information about the pbs-devel mailing list