[pbs-devel] [PATCH proxmox-backup] pxar-bin: remove `log` dependency, use `tracing` directly

Christian Ebner c.ebner at proxmox.com
Wed Sep 4 14:31:06 CEST 2024


On 9/4/24 10:06, Christian Ebner wrote:
> small nits inline
> 
> As you already discussed with Wolfgang in the other thread, any user 
> facing output not intended for debugging, e.g. the output of the `pxar 
> list` might be better displayed by writing to stdout using a `println` 
> instead.
> 
> Tested by listing and extracting a pxar archive, with and without the 
> `PXAR_LOG=debug` environment variable set.
> 
> Other than that, please consider this and the patch to `proxmox-log`:
> 
> Tested-by: Christian Ebner <c.ebner at proxmox.com>
> Reviewed-by: Christian Ebner <c.ebner at proxmox.com>
> 

Also, this needs a `cargo fmt` to correctly sort the entities in the 
proxmox_log use statement.





More information about the pbs-devel mailing list