[pbs-devel] [PATCH backup/proxmox-backup 0/4] fix #5463: add optional consent banner before login

Gabriel Goller g.goller at proxmox.com
Wed May 22 15:19:40 CEST 2024


This has been requested many times already for all products. To keep 
it simple as it's still quite a niche feature, works with a single file:
/etc/proxmox-backup/consent.txt. If the file exists and is not empty, 
a consent banner will be shown in front of the login view.

This is just a reference implementation for pbs to get some feedback
and check if my general approach is alright. The same implementation 
will then be ported to pve and eventually pmg.

Another disclaimer: IANAL (I am not a lawyer :) ), so the wording is 
probably off. 

v1, thanks @Dominik:
 - embed consent text into index.html file instead of extra api request
 - removed decline button
 - added alwaysOnTop property to popup

widget-toolkit:

Gabriel Goller (3):
  api: add consent api handler and config
  ui: show consent banner before login
  docs: add section about consent banner

 docs/gui.rst                    |  7 +++++++
 src/bin/proxmox-backup-proxy.rs |  6 ++++++
 src/config/consent.rs           | 11 +++++++++++
 src/config/mod.rs               |  1 +
 www/LoginView.js                |  9 +++++++++
 www/index.hbs                   |  1 +
 6 files changed, 35 insertions(+)
 create mode 100644 src/config/consent.rs


backup:

Gabriel Goller (1):
  window: add consent modal

 src/Makefile               |  1 +
 src/window/ConsentModal.js | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100644 src/window/ConsentModal.js


Summary over all repositories:
  8 files changed, 70 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.5.0




More information about the pbs-devel mailing list