[pbs-devel] [PATCH v8 proxmox-backup 56/69] pxar: ignore version and prelude entries in listing

Christian Ebner c.ebner at proxmox.com
Tue Jun 4 10:48:22 CEST 2024


On 6/4/24 10:39, Fabian Grünbichler wrote:
> On May 28, 2024 11:42 am, Christian Ebner wrote:
>> Do not list the pxar format version and the prelude entries in the
>> output of pxar list, these are not regular entries.
> 
> I think it might still be nice to print at least the version in
> debugging mode? the prelude might be a bit hard, since it's an opaque
> blob of bytes, but we could also dump their existence/length or their
> base64- or hex-encoded contents?

While I agree that adding the presence of the entries (at least in debug 
mode) makes sense, I do not agree on dumping the contents of the 
Prelude, because that currently is only encoding the pxar exclude cli 
parameters, but might contain further, possibly also a lot more 
information in the future?

So dumping this seems not the best approach, especially since one 
already can restore this contents to a dedicated file if wanted/needed.





More information about the pbs-devel mailing list