[pbs-devel] [PATCH v8 proxmox-backup 56/69] pxar: ignore version and prelude entries in listing

[Fabian Grünbichler]

On May 28, 2024 11:42 am, Christian Ebner wrote:
> Do not list the pxar format version and the prelude entries in the
> output of pxar list, these are not regular entries.

I think it might still be nice to print at least the version in
debugging mode? the prelude might be a bit hard, since it's an opaque
blob of bytes, but we could also dump their existence/length or their
base64- or hex-encoded contents?

since patch #38 also adds the padding lines there, the output with level
debug already contains lines which are not just the regular entry
information..

> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 7:
> - no changes
> 
> changes since version 6:
> - not present
> 
>  pxar-bin/src/main.rs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pxar-bin/src/main.rs b/pxar-bin/src/main.rs
> index 2cf8def53..69d948e73 100644
> --- a/pxar-bin/src/main.rs
> +++ b/pxar-bin/src/main.rs
> @@ -484,6 +484,7 @@ fn dump_archive(archive: String, payload_input: Option<String>) -> Result<(), Er
>  
>          if log::log_enabled!(log::Level::Debug) {
>              match entry.kind() {
> +                EntryKind::Version(_) | EntryKind::Prelude(_) => continue,
>                  EntryKind::File {
>                      payload_offset: Some(offset),
>                      size,
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>