[pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function

Christian Ebner c.ebner at proxmox.com
Thu Jul 4 11:59:22 CEST 2024


On 7/3/24 16:58, Gabriel Goller wrote:
> `list_snapshots_blocking` doesn't need to be unsafe.

I think that this is intentionally marked as `unsafe` to make sure the 
caller really does look at the possible consequences of calling this 
method. As documented, "This must not run in a main worker thread as it 
potentially does tons of I/O."

So rather than dropping the `unsafe`, maybe clarify that this is the 
reason for it being declared as unsafe in the comment.

But I guess Wolfgang can comment more on this.





More information about the pbs-devel mailing list