[pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function

Gabriel Goller g.goller at proxmox.com
Wed Jul 3 16:58:53 CEST 2024


`list_snapshots_blocking` doesn't need to be unsafe.

Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
---
 src/api2/admin/datastore.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index 82221c503d16..f28fb97fa975 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -451,7 +451,7 @@ pub async fn list_snapshots(
 ) -> Result<Vec<SnapshotListItem>, Error> {
     let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?;
 
-    tokio::task::spawn_blocking(move || unsafe {
+    tokio::task::spawn_blocking(move || {
         list_snapshots_blocking(store, ns, backup_type, backup_id, auth_id)
     })
     .await
@@ -459,7 +459,7 @@ pub async fn list_snapshots(
 }
 
 /// This must not run in a main worker thread as it potentially does tons of I/O.
-unsafe fn list_snapshots_blocking(
+fn list_snapshots_blocking(
     store: String,
     ns: Option<BackupNamespace>,
     backup_type: Option<BackupType>,
-- 
2.43.0





More information about the pbs-devel mailing list