[pbs-devel] [PATCH proxmox-backup 00/33] integrate notification system
Gabriel Goller
g.goller at proxmox.com
Wed Apr 17 12:26:51 CEST 2024
On Wed Apr 17, 2024 at 10:22 AM CEST, Lukas Wagner wrote:
> On second thought: I think I want to use the 'old system' by default for anything
> that might be automated in some fashion (e.g. calling proxmox-backup-manager from a script, or
> creating a datastore via the API).
Ooh, this is actually a good point, this could then be changed on a
future (prob. major) update!
Disregard my comment earlier then :)
> Because a `proxmox-backup-manager datastore create ... --notify gc=never`
> (or an equivalent API call) would suddenly behave differently if we default to
> the notification system (--notify is ignored then).
> In the web UI it seems fine to automatically opt-in (we don't offer the option to change
> notification settings there anyway), but for the CLI/API I'm not sure
> if this is a good idea.
>
> We *could* have some magic approach which opts into the notification system iff
> - mailto-user is *not* set (we defaulted to sending to root at pam then)
> - notify is also *not* set
>
> But I'm not sure if I'm a fan of that - the 'auto' mode for backup jobs on PVE created
> enough confusion already, so I'd rather be more explicit here - even if that
> means that we have an opt-in approach until the next major release.
More information about the pbs-devel
mailing list