[pbs-devel] [PATCH proxmox-backup 00/33] integrate notification system

[Lukas Wagner]

On  2024-04-12 16:09, Lukas Wagner wrote:
> On 12.04.24 15:59, Gabriel Goller wrote:
>> Another thing I noticed is that creating a datastore through the cli 
>> still uses the legacy notification system.
>>
> 
> Ah, thx!
> 

On second thought: I think I want to use the 'old system' by default for anything
that might be automated in some fashion (e.g. calling proxmox-backup-manager from a script, or
creating a datastore via the API).
Because a `proxmox-backup-manager datastore create ... --notify gc=never` 
(or an equivalent API call) would suddenly behave differently if we default to
the notification system (--notify is ignored then).
In the web UI it seems fine to automatically opt-in (we don't offer the option to change
notification settings there anyway), but for the CLI/API I'm not sure
if this is a good idea.

We *could* have some magic approach which opts into the notification system iff
  - mailto-user is *not* set (we defaulted to sending to root at pam then)
  - notify is also *not* set

But I'm not sure if I'm a fan of that - the 'auto' mode for backup jobs on PVE created
enough confusion already, so I'd rather be more explicit here - even if that
means that we have an opt-in approach until the next major release.


-- 
- Lukas