[pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position
t.lamprecht at proxmox.com
Mon Oct 16 12:04:12 CEST 2023
Am 16/10/2023 um 11:51 schrieb Gabriel Goller:
> On 10/13/23 15:04, Dominik Csapak wrote:
>> we could also create our own class that uses the gif as a background image, or
>> simply embed the gif directly? then we'd keep the image and could still
>> add a translated text
> To be honest, I wouldn't add a text. We would have to separate between 'Running'
> and 'Loading', because that's not the same thing (e.g., in pbs we use the spinner
> on the snapshot size—where it would be 'Loading'
No, there it would be running to, as that indicates that there's no
size available due to a currently running job; or do you mean
> —and on the task log—where it would
> be 'Running'). Then we would also have to adjust some tables, because the 'Running'
> or 'Loading' text won't fit (As far as I know, they use a fixed width).
To clarify, I'd explicitly only left-align those spinners for when
used as job running spinners, not for loading – and IIRC we do not
have any per-cell or per-row loading indicators anyway, as we always
load all data of a grid at once (or at least fake doing so), but never
row or even cell-wise.
So moving this new alignment behavior into its own class, that derives
from the ExtJS one, seems more reasonable to avoid odd rendering issues
for the cases where the left-alignment isn't desired.
If we then add a text to that is an independent decision, but it surely
wouldn't hurt accessibility.
More information about the pbs-devel