[pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position

Gabriel Goller g.goller at proxmox.com
Mon Oct 16 11:51:30 CEST 2023

On 10/13/23 15:04, Dominik Csapak wrote:
> [..]
>> Having something like "Running" as text here would be nice, but  we
>> cannot just use a `.x-grid-row-loading:after { content: 'Running' }`
>> as that misses translations.
>> One option would be to avoid ExtJS CSS here and use font-awesome like
>> "fa fa-fw fa-circle-o-notch fa-spin", the only disadvantage from that
>> is that we lose the site-wide synced animation that the currently used
>> GIF provides, can be worked around but IIRC there's nothing native
>> available for doing so.
> we could also create our own class that uses the gif as a background 
> image, or
> simply embed the gif directly? then we'd keep the image and could still
> add a translated text
To be honest, I wouldn't add a text. We would have to separate between 
and 'Loading', because that's not the same thing (e.g., in pbs we use 
the spinner
on the snapshot size—where it would be 'Loading'—and on the task 
log—where it would
be 'Running'). Then we would also have to adjust some tables, because 
the 'Running'
or 'Loading' text won't fit (As far as I know, they use a fixed width).
>> For now the adapted CSS would be an OK stop-gap, IIRC we only use such
>> grid loading classes for such scheduled-job grids. Adding it to PVE
>> (isn't there even anything besides replication using that?) would be
>> good too though. IMO no need for widget toolkit, I'd keep this contained
>> for now.
> we use that for running tasks and replication, and the class
> 'x-grid-row-loading' is the same for pve/pmg/pbs (so i thought it might
> warrant to have it in widget toolkit, so that we can remove it from the
> individual projects' css files)
Right, we can do that, should be a fairly simple change as well.

More information about the pbs-devel mailing list