[pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion

Philipp Hufnagl p.hufnagl at proxmox.com
Fri Oct 13 16:57:54 CEST 2023

On 10/13/23 13:30, Thomas Lamprecht wrote:
> Am 03/10/2023 um 16:07 schrieb Philipp Hufnagl:
>> -    Ok(result)
>> +    println!("Successfully deleted snapshot {}", snapshot);
> please use inline variables wherever easily possible for new code:
> println!("Successfully deleted snapshot {snapshot}");
> but I'm not sure if we actually want to print anything here, did you
> check what the other "action" (i.e., non-GET ones) do, If they all,
> or at least most of them, print such reports too it can be fine, but
> otherwise this would add inconsistency and simply doing nothing (i.e.,
> exiting with SUCCESS) would be enough.

You are right! For example 'proxmox-backup-client snapshot notes
update' does not produce any output. Ill make a v 2 on Monday removing
the output!

More information about the pbs-devel mailing list