[pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 13 13:30:05 CEST 2023

Am 03/10/2023 um 16:07 schrieb Philipp Hufnagl:
> -    Ok(result)
> +    println!("Successfully deleted snapshot {}", snapshot);

please use inline variables wherever easily possible for new code:

println!("Successfully deleted snapshot {snapshot}");

but I'm not sure if we actually want to print anything here, did you
check what the other "action" (i.e., non-GET ones) do, If they all,
or at least most of them, print such reports too it can be fine, but
otherwise this would add inconsistency and simply doing nothing (i.e.,
exiting with SUCCESS) would be enough.

More information about the pbs-devel mailing list