[pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position

Dominik Csapak d.csapak at proxmox.com
Thu Oct 12 14:34:36 CEST 2023


On 10/12/23 13:49, Gabriel Goller wrote:
> On 10/12/23 11:28, Dominik Csapak wrote:
>> *if* we want to change this, we either would have to adapt pve/pmg as well,
>> or refactor the class into the widget-toolkit (idk if there are some differences
>> across products, though it shouldn't be), because we also use that for the task
>> and job status list (e.g. replication)
> 
> I looked at them briefly and they have a few things in common, but imo
> it's not worth the hassle combining them. We wouldn't **need** this in
> pve/pmg but I could still submit a patch... let me know.
> 
>>

Depends on your definition of **need**. If we don't do this,
it would look differently e.g. for the task list in pve/pmg vs pbs
and we want to have the UI consistent across products
(except if there is a good reason to diverge) so for me it is
important to stay consistent here.

@Thomas any opinion on this?





More information about the pbs-devel mailing list