[pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position

Gabriel Goller g.goller at proxmox.com
Thu Oct 12 13:49:31 CEST 2023

On 10/12/23 11:28, Dominik Csapak wrote:

> On 9/13/23 16:20, Gabriel Goller wrote:
>> When displaying the status of a job (sync, gc, etc..) the 'OK'
>> and 'Error' text uses a padding of 10px to the left. The
>> loading spinner is centered in the cell though. This doesn't
>> look that good.
> this is debatable, and having the 'loading' state stand out, makes 
> sense imo.
No hard feelings from me either to be honest. It just doesn't look that 
good (imo)
when having a short text and long rows (as in the new gc view).

> *if* we want to change this, we either would have to adapt pve/pmg as 
> well,
> or refactor the class into the widget-toolkit (idk if there are some 
> differences
> across products, though it shouldn't be), because we also use that for 
> the task
> and job status list (e.g. replication)

I looked at them briefly and they have a few things in common, but imo
it's not worth the hassle combining them. We wouldn't **need** this in
pve/pmg but I could still submit a patch... let me know.

> [..]

More information about the pbs-devel mailing list