[pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow setting a time on which prune happens

[Matthias Heiserer]

On 16.09.2022 12:08, Fiona Ebner wrote:
> Same nit for the commit title.
> 
> Am 14.09.22 um 12:50 schrieb Matthias Heiserer:
>> @@ -726,6 +730,15 @@ Ext.onReady(function() {
>>   					    padding: '0 0 0 10',
>>   					    value: new Date(),
>>   					},
>> +					{
>> +					    xtype: 'timefield',
>> +					    name: 'currentTime',
>> +					    reference: 'currentTime',
>> +					    fieldLabel: 'Time of prune',
> 
> I don't really like using "Time of prune" here, because the setting also
> affects the schedule and doesn't feel in line with "Today". How about
> "Today's time" or simply "Time"? Or we could use "Current date" and
> "Current time".
I think just "Time" works best. I'll also rename the date field to 
"Date" to keep it consistent (and because it makes more sense; from the 
view of the user, its not the current date, but the date which is used 
for the simulation).
> 
> There's AM/PM times in the drop-down suggestions here, which clashes
> with the 24 hour format used in the rest of the simulator. Let's try to
> keep it consistent.
> 
Of course, good catch
>> +					    allowBlank: false,
>> +					    padding: '0 0 0 10',
>> +					    value: new Date(),
>> +					},
>>   				    ],
>>   				},
>>   			    ],