[pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow setting a time on which prune happens

Fiona Ebner f.ebner at proxmox.com
Fri Sep 16 12:08:41 CEST 2022


Same nit for the commit title.

Am 14.09.22 um 12:50 schrieb Matthias Heiserer:
> @@ -726,6 +730,15 @@ Ext.onReady(function() {
>  					    padding: '0 0 0 10',
>  					    value: new Date(),
>  					},
> +					{
> +					    xtype: 'timefield',
> +					    name: 'currentTime',
> +					    reference: 'currentTime',
> +					    fieldLabel: 'Time of prune',

I don't really like using "Time of prune" here, because the setting also
affects the schedule and doesn't feel in line with "Today". How about
"Today's time" or simply "Time"? Or we could use "Current date" and
"Current time".

There's AM/PM times in the drop-down suggestions here, which clashes
with the 24 hour format used in the rest of the simulator. Let's try to
keep it consistent.

> +					    allowBlank: false,
> +					    padding: '0 0 0 10',
> +					    value: new Date(),
> +					},
>  				    ],
>  				},
>  			    ],





More information about the pbs-devel mailing list