[pbs-devel] [PATCH proxmox-backup v3] fix #3854 paperkey import to proxmox-tape

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Mar 4 13:31:09 CET 2022


On Fri, Mar 04, 2022 at 12:50:07PM +0100, Dominik Csapak wrote:
> On 3/4/22 12:02, Wolfgang Bumiller wrote:
> > nit: @Dominik (since you suggested it):
> > do we really want `-file` as a suffix here?
> > 
> > We have these currently:
> > in recover:
> >      --file
> >      --keyfile (without the dash), and
> > in 'inspect':
> >      --chunk => chunk file
> >      --decode => apparently where to decode*to*  🤔
> >      --keyfile (also no dash)
> > manager's 'acme':
> >      --data => path to plugin-data file
> > 
> > should we just use `--paperkey` here?
> 
> meh...
> 
> '--paperkey': would fit into the existing scheme, but implies
>   giving the content, not a file...

I disagree.

> 
> '--paperkeyfile': it's ugly
> 
> so i suggested '--paperkey-file'...
> 
> but we can ofc use '--paperkey' here, maybe try
> to use the content directly if it isn't an existing path?

Please no!

Well... @Markus, your choice, you can pick one of `--paperkey` or
`--paperkey-file`,
(and maybe we should rename `--keyfile` to `--key-file`...)




More information about the pbs-devel mailing list