[pbs-devel] [PATCH proxmox-backup v3] fix #3854 paperkey import to proxmox-tape

Dominik Csapak d.csapak at proxmox.com
Fri Mar 4 12:50:07 CET 2022


On 3/4/22 12:02, Wolfgang Bumiller wrote:
> nit: @Dominik (since you suggested it):
> do we really want `-file` as a suffix here?
> 
> We have these currently:
> in recover:
>      --file
>      --keyfile (without the dash), and
> in 'inspect':
>      --chunk => chunk file
>      --decode => apparently where to decode*to*  🤔
>      --keyfile (also no dash)
> manager's 'acme':
>      --data => path to plugin-data file
> 
> should we just use `--paperkey` here?

meh...

'--paperkey': would fit into the existing scheme, but implies
   giving the content, not a file...

'--paperkeyfile': it's ugly

so i suggested '--paperkey-file'...

but we can ofc use '--paperkey' here, maybe try
to use the content directly if it isn't an existing path?

then the implication would at least work...

idk, i'm not the best person to deal with naming things...





More information about the pbs-devel mailing list