[pbs-devel] applied-series: [PATCH proxmox-backup v4 0/7] add 'proxmox-backup-debug api' commands

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Sep 21 15:45:51 CEST 2021


On 21.09.21 12:11, Dominik Csapak wrote:
> this series is a successor to my previous 'pbs-shell' series [0]
> code wise its mostly the same but now a subcommand of 'proxmox-backup-debug'
> 
> changes from v3:
> * rebase on master (use normalize_path_uri from proxmox_rest_server)
> * fix worker task log output (upid was not wrapped in {data:upid})
> 
> changes from v2:
> * now subcommand api of proxmox-backup-debug
> * use http api on localhost by default
> * add PROXMOX_DEBUG_API_CODE env variable to execute code directly
> * use a macro for the completion helper calls
> * combine get/post/put/delete requests into one and use 'fixed_param'
> * drop priviliges to the backup user when executing 'non-protected' api
>   calls directly
> 
> changes from v1:
> * rebase on master
> * rename 'path' parameter to 'api-path' since it clashed with some
>   api calls that had a 'path variable'
> * better handle workers:
>   we must always wait for the local workers and do not need to
>   print their logs, since most workers print to stdout if the
>   rpcenv type is CLI. Also catch Ctrl+C and try to abort the worker
> 
> 0: https://lists.proxmox.com/pipermail/pbs-devel/2021-September/003974.html
> 
> Dominik Csapak (7):
>   server: refactor abort_local_worker
>   move proxmox-backup-debug back to main crate
>   proxmox-backup-debug: add 'api' subcommands
>   api2: add missing token list match_all property
>   api2: make some workers log on CLI
>   docs: add proxmox-backup-debug to the list of command line tools
>   docs: proxmox-backup-debug: add info about the 'api' subcommand

applied, thanks!

for `ls` I made the path optional with "/" as default in a followup, irked a bit
in pvesh since quite a bit (but not yet done there)





More information about the pbs-devel mailing list