[pbs-devel] [PATCH proxmox/proxmox-backup v2] add 'pbs-shell' tool

Dominik Csapak d.csapak at proxmox.com
Mon Sep 13 16:18:21 CEST 2021


this series adds the tool 'pbs-shell', similar to 'pvesh' and 'pmgsh'
this tool is intended mainly for debugging, but can be useful for
api calls not exposed via the client/manager.

proxmox (and the dependency in proxmox-backup) need to be bumped

proxmox-backup patches 3-6 are not strictly necessary, but improve
the api so that the 'ls' command works better
(there are still some api paths to be fixed)

patch 7 is als not strictly necessary, but changes some workers
to print to stdout on the cli

changes from v1:
* rebase on master
* rename 'path' parameter to 'api-path' since it clashed with some
  api calls that had a 'path variable'
* better handle workers:
  we must always wait for the local workers and do not need to
  print their logs, since most workers print to stdout if the
  rpcenv type is CLI. Also catch Ctrl+C and try to abort the worker

proxmox:

Dominik Csapak (1):
  proxmox: generate_usage_str: don't require static lifetimes

 proxmox/src/api/cli/format.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

proxmox-backup:

Dominik Csapak (7):
  server: refactor abort_local_worker
  add 'pbs-shell' utility
  api2: add missing token list match_all property
  api2: disks/directory: refactor BASE_MOUNT_DIR
  api2: disks/directory: add 'name' property to directory mount listing
  api2: nodes: add missing node list api call
  api2: make some workers log on CLI

 Makefile                                     |   2 +
 debian/pbs-shell.bc                          |   3 +
 debian/proxmox-backup-server.bash-completion |   1 +
 debian/proxmox-backup-server.install         |   3 +
 docs/Makefile                                |   8 +
 docs/pbs-shell/description.rst               |   3 +
 docs/pbs-shell/man1.rst                      |  40 ++
 src/api2/access/user.rs                      |  35 +-
 src/api2/admin/datastore.rs                  |   4 +-
 src/api2/admin/sync.rs                       |   6 +-
 src/api2/admin/verify.rs                     |   5 +-
 src/api2/config/datastore.rs                 |   5 +-
 src/api2/mod.rs                              |   4 +-
 src/api2/node/disks/directory.rs             |  15 +-
 src/api2/node/mod.rs                         |  12 +-
 src/api2/node/tasks.rs                       |   2 +-
 src/api2/pull.rs                             |   3 +-
 src/api2/tape/backup.rs                      |   7 +-
 src/bin/pbs-shell.rs                         | 528 +++++++++++++++++++
 src/bin/proxmox-backup-proxy.rs              |   4 +-
 src/server/verify_job.rs                     |   3 +-
 src/server/worker_task.rs                    |  12 +-
 zsh-completions/_pbs-shell                   |  13 +
 23 files changed, 688 insertions(+), 30 deletions(-)
 create mode 100644 debian/pbs-shell.bc
 create mode 100644 docs/pbs-shell/description.rst
 create mode 100644 docs/pbs-shell/man1.rst
 create mode 100644 src/bin/pbs-shell.rs
 create mode 100644 zsh-completions/_pbs-shell

-- 
2.30.2






More information about the pbs-devel mailing list