[pbs-devel] [PATCH backup] client: use build_authority in build_uri

[Wolfgang Bumiller]

On Thu, May 06, 2021 at 09:34:03AM +0200, Dietmar Maurer wrote:
> > On 05/06/2021 9:14 AM Wolfgang Bumiller <w.bumiller at proxmox.com> wrote:
> > 
> >  
> > On Thu, May 06, 2021 at 09:01:46AM +0200, Dietmar Maurer wrote:
> > > In general a good idea, but we now merge code
> > > from two independent http client implementation (making them
> > > dependent)?
> > 
> > I mean... it's called "tools::http"... as in "http utilities", which
> > IMO does not really sound like "this is an independent http client,
> > which must not be reused"... ;-)
> 
> What naming do you suggest instead?

I suppose I'd put shared http stuff in `tools::http` and if the client
should be separate I'd suggest `tools::http::client`, but I'm not
convinced it cannot stay as is while sharing some code in the first
place

> 
> > And it's a rather thin layer around hyper (the *actual* client...) to
> > add proxy support which, too, is something that we may at some point
> > want to reuse without the rest of `SimpleHttp`, no?
> 
> I am not sure if it is worth to reuse that for that backup client. We simply
> do not need proxy support there.

yet ;-)