[pbs-devel] [PATCH backup] client: use build_authority in build_uri

Dietmar Maurer dietmar at proxmox.com
Thu May 6 09:34:03 CEST 2021


> On 05/06/2021 9:14 AM Wolfgang Bumiller <w.bumiller at proxmox.com> wrote:
> 
>  
> On Thu, May 06, 2021 at 09:01:46AM +0200, Dietmar Maurer wrote:
> > In general a good idea, but we now merge code
> > from two independent http client implementation (making them
> > dependent)?
> 
> I mean... it's called "tools::http"... as in "http utilities", which
> IMO does not really sound like "this is an independent http client,
> which must not be reused"... ;-)

What naming do you suggest instead?

> And it's a rather thin layer around hyper (the *actual* client...) to
> add proxy support which, too, is something that we may at some point
> want to reuse without the rest of `SimpleHttp`, no?

I am not sure if it is worth to reuse that for that backup client. We simply
do not need proxy support there.





More information about the pbs-devel mailing list