[pbs-devel] [PATCH proxmox-backup] client/pull: log snapshots that are skipped because of time

[Thomas Lamprecht]

On 04.06.21 10:21, Fabian Grünbichler wrote:
> On June 4, 2021 9:16 am, Dominik Csapak wrote:
>> @@ -495,6 +496,11 @@ pub async fn pull_group(
>>  
>>          if let Some(last_sync_time) = last_sync {
>>              if last_sync_time > backup_time {
>> +                task_log!(
>> +                    worker,
>> +                    "skipping snapshot {} - older than last sync",
>> +                    snapshot
>> +                );
> 
> adding this would mean that sync logs would grow and grow and grow over 
> time..
> 
> maybe a single:
> 
> skipped 32 remote snapshots (2021-MM-DDTHH:MM::SSZ..2021-MM-DDTHH:MM::SSZ) older than newest local snapshot.
> 
> it would mean only adding a single line to the output, but contains 
> almost all the information?

If we want to just log that for now that this is def. the more sensible approach,
task logs should be always as readable, where less to read without losing any, or
at least not much, information is always nice, so:

+1