[pbs-devel] [PATCH proxmox-backup] client/pull: log snapshots that are skipped because of time

Dietmar Maurer dietmar at proxmox.com
Fri Jun 4 11:03:24 CEST 2021


On 6/4/21 10:21 AM, Fabian Grünbichler wrote:
>
>> @@ -495,6 +496,11 @@ pub async fn pull_group(
>>   
>>           if let Some(last_sync_time) = last_sync {
>>               if last_sync_time > backup_time {
>> +                task_log!(
>> +                    worker,
>> +                    "skipping snapshot {} - older than last sync",
>> +                    snapshot
>> +                );
> adding this would mean that sync logs would grow and grow and grow over
> time..
>
> maybe a single:
>
> skipped 32 remote snapshots (2021-MM-DDTHH:MM::SSZ..2021-MM-DDTHH:MM::SSZ) older than newest local snapshot.
>
> it would mean only adding a single line to the output, but contains
> almost all the information?
>
I would also prefer a single log line.







More information about the pbs-devel mailing list