[pbs-devel] [PATCH proxmox-backup v2] ui: NodeInfo: add link to repositories
Dominik Csapak
d.csapak at proxmox.com
Tue Jul 13 12:58:49 CEST 2021
to guide the user to the repository panel from the dashboard
Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
changes from v1:
* use different icon
* make sure the icon stays black
(i did not see the purple link... should check my eyes^^)
* use better variable name
* use tooltip
regarding the use of a 'normal' link, there are two alternatives as i
see it, and both are not optimal:
* create an component inline (Ext.create) and add a handler, etc.
i'd avoid that in a viewmodel formula (do not know the side effects
of that)
* add a click handler/tooltip across the whole 'value' part of the panel
idk if we want that, it would mean the tooltip/click handler is for
the whole value part
if one of those solutions is preferred, please tell, i'll send a v3
www/panel/NodeInfo.js | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js
index ff96e8fc..a8c450f6 100644
--- a/www/panel/NodeInfo.js
+++ b/www/panel/NodeInfo.js
@@ -46,7 +46,11 @@ Ext.define('PBS.NodeInfoPanel', {
},
repoStatusMessage: function(get) {
const status = get('repoStatus');
- return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server');
+ let repoLink = ` <a data-qtip="${gettext("Open Repositories Panel")}"
+ href="#pbsServerAdministration:aptrepositories">
+ <i class="fa black fa-chevron-right"></i>
+ </a>`;
+ return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server') + repoLink;
},
},
},
--
2.30.2
More information about the pbs-devel
mailing list