[pbs-devel] applied: [PATCH v2 proxmox-backup 1/2] file-restore: increase lock timeout on QEMU map

Dietmar Maurer dietmar at proxmox.com
Tue Jul 13 12:08:18 CEST 2021


applied

On 7/13/21 11:23 AM, Stefan Reiter wrote:
> This lock is held during VM startup, so that multiple calls will not
> start VMs twice. But this means that the timeout needs to incorporate
> the time it might take a VM to boot, so increase it quite a bit.
>
> This could previously lead to "interrupted system call" errors when
> accessing backups with many disks.
>
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>
> v2: unchanged
>
>   src/bin/proxmox_file_restore/block_driver_qemu.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/proxmox_file_restore/block_driver_qemu.rs b/src/bin/proxmox_file_restore/block_driver_qemu.rs
> index 24f62796..46d91198 100644
> --- a/src/bin/proxmox_file_restore/block_driver_qemu.rs
> +++ b/src/bin/proxmox_file_restore/block_driver_qemu.rs
> @@ -50,7 +50,7 @@ impl VMStateMap {
>       /// Acquire a lock on the state map and retrieve a deserialized version
>       fn load() -> Result<Self, Error> {
>           let mut file = Self::open_file_raw(true)?;
> -        lock_file(&mut file, true, Some(std::time::Duration::from_secs(5)))?;
> +        lock_file(&mut file, true, Some(std::time::Duration::from_secs(120)))?;
>           let map = serde_json::from_reader(&file).unwrap_or_default();
>           Ok(Self { map, file })
>       }





More information about the pbs-devel mailing list