[pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas

[Dominic Jäger]

Thanks for looking at it!

On Tue, Jan 26, 2021 at 11:34:54AM +0100, Dominik Csapak wrote:
> when we have the error icon, we'd not need the asterisk,
> since they both show the error
We could theoretically show the asterisk without any color, just to symbolise
"Required". But the error message shows this problem, too. So yes, it is
redundant in some way.

> or were they not intended to be applied together?
It was intended to be applicable together, but only to easily show the
possibilities together. Not because I absolutely want all of the patches to be
applied.

> also, the generic tooltip does always show on the whole
> element for me, so with either the asterisk or the
> icon, i still get multiple tooltips over one another
Same for me. But the error message should appear only if you hover over the
asterisk or the symbol. This means
1. if you hover over the error symbol, the error message is above the generic
   tooltip. Then you see what is wrong.
2. if you hover over the field, the error message vanishes and you see what you
   are supposed to enter into the field.

Without msgTarget: side the error tooltip should also appear if you hover over
the input field. Then you only see the generic tooltip when you hover over the
label, which is a little less intuitive than 2., I think.
> 
> another problem is with the detection of the 'required'
> error. while this may work on english, extjs
> errors are also translated, though i noticed we do
> not do this yet for pbs (for pve we do)
> so filtering by 'required' cannot work for other languages
Makes sense, I missed that.
> 
> and last but not least:
> would it not be possible to show the tooltip just on the
> label?
> e.g.:
> 
> ---
> fieldLabel: `<div qtip="sometext">${gettext('labeltext')}</div>'
> ---
I could not get this to work yet and I am not sure if it is possible?
The "Remote" field has xtype pmxDisplayEditField

> Ext.define('Proxmox.form.field.DisplayEdit', {
>     extend: 'Ext.form.FieldContainer',
>     alias: 'widget.pmxDisplayEditField',

and then fieldLabel is just a String, no HTML?
https://docs.sencha.com/extjs/6.0.1/classic/Ext.form.FieldContainer.html#cfg-fieldLabel

> 
> a little bit less intuitive, but should not create overlapping
> tooltips
This means we would have the same messages visible as currently?
1. Generic tool while hovering over label
2. Error message else (= hovering over field)

> 
> another alternative would be to add a displayfield below the
> field with an explanation?
Sounds good to me. Downside in comparison to tooltips would be limited amount
of text for the hints?

> 
> or simply add a screenshot with a list of fields to the documentation?
List of fields + what belongs into them? Isn't that quite much work to look up
"just" to fill out a field?