[pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas

[Dominik Csapak]

ok after taking a look at it, there are some problems

while i'd find the asterisk ok, the combination of patches
here do not really work together well.

when we have the error icon, we'd not need the asterisk,
since they both show the error or were they not intended
to be applied together?

also, the generic tooltip does always show on the whole
element for me, so with either the asterisk or the
icon, i still get multiple tooltips over one another

another problem is with the detection of the 'required'
error. while this may work on english, extjs
errors are also translated, though i noticed we do
not do this yet for pbs (for pve we do)
so filtering by 'required' cannot work for other languages

and last but not least:
would it not be possible to show the tooltip just on the
label?
e.g.:

---
fieldLabel: `<div qtip="sometext">${gettext('labeltext')}</div>'
---

a little bit less intuitive, but should not create overlapping
tooltips

another alternative would be to add a displayfield below the
field with an explanation?

or simply add a screenshot with a list of fields to the documentation?

On 1/19/21 12:09 PM, Dominic Jäger wrote:
> Already talked about the first patch for #3058 with Thomas. Hope that this is
> now acceptable.
> 
> The rest is rather to show what we could maybe do and how much code that would
> require.
> 
> Dominic Jäger (4):
>    ui: remote edit: Add tooltips
>    ui: remote edit: Add asterisks
>    ui: remote edit: Error as symbol to the right
>    ui: remote edit: Change asterisk color
> 
>   www/Utils.js             | 15 +++++++++++++++
>   www/window/RemoteEdit.js | 35 +++++++++++++++++++++++++++++++++++
>   2 files changed, 50 insertions(+)
>