[pbs-devel] [PATCH proxmox-backup 09/22] client: extract common functions to proxmox_client_tools module

Dietmar Maurer dietmar at proxmox.com
Wed Feb 17 09:50:12 CET 2021


> On 02/17/2021 8:58 AM Stefan Reiter <s.reiter at proxmox.com> wrote:
> 
>  
> On 17/02/2021 07:49, Dietmar Maurer wrote:
> > I thought we can put all client related code into src/client/
> > 
> > So why starting another lib inside src/bin/proxmox_client_tools/?
> > 
> 
> Why was (part of) it initially in src/bin/proxmox_backup_client then and 
> not src/client/ ? I thought it was to seperate the "binary-specific" 
> client code from more generic client code (such as used in pull or the 
> QEMU library as well).

Ok, but why do you move cli functions like:

fn paper_key()
fn show_key()


Those belongs to proxmox-backup-client - or do we reuse them somewhere?





More information about the pbs-devel mailing list