[pbs-devel] [PATCH proxmox-backup 09/22] client: extract common functions to proxmox_client_tools module

[Stefan Reiter]

On 17/02/2021 07:49, Dietmar Maurer wrote:
> I thought we can put all client related code into src/client/
> 
> So why starting another lib inside src/bin/proxmox_client_tools/?
> 

Why was (part of) it initially in src/bin/proxmox_backup_client then and 
not src/client/ ? I thought it was to seperate the "binary-specific" 
client code from more generic client code (such as used in pull or the 
QEMU library as well).

Wouldn't mind putting it in src/client either though.

> 
>> On 02/16/2021 6:06 PM Stefan Reiter <s.reiter at proxmox.com> wrote:
>>
>>   
>> ...including common schemata, connect(), extract_*() and completion
>> functions.
>>
>> For later use with proxmox-file-restore binary.
>>
>> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
>> ---
>>   src/bin/proxmox-backup-client.rs    | 361 +--------------------------
>>   src/bin/proxmox_client_tools/mod.rs | 366 ++++++++++++++++++++++++++++