[PVE-User] qemu-server: bug in vmconfig_apply_pending errors handling

alexandre derumier aderumier at odiso.com
Sun Jul 4 19:29:20 CEST 2021


Hi,

I'm still working on ipam support for qemu-server,

I have notice a bug in error handling of offline change apply, since
commit

https://git.proxmox.com/?p=qemu-server.git;a=commit;h=eb5e482ded9ae6aeb6575de9441b79b90a5de531

introduce $errors support



API2/Qemu.pm

-
               PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $
storecfg, $running);
+               PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $
storecfg, $running, $errors);

PVE/QemuServer.pm
 sub vmconfig_apply_pending {
-    my ($vmid, $conf, $storecfg) = @_;
+    my ($vmid, $conf, $storecfg, $errors) = @_;


The problem is the $running param used,  not existing in the sub.





More information about the pve-user mailing list